Re: should I post the patch as committed? - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: should I post the patch as committed?
Date
Msg-id h2o9837222c1004201004g293da98bp593f073839d66b97@mail.gmail.com
Whole thread Raw
In response to Re: should I post the patch as committed?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: should I post the patch as committed?  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On Tue, Apr 20, 2010 at 18:30, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> Bruce suggested to me off-list that when I commit a patch with
>> revisions, I ought to attach the committed patch to the email in which
>> I say that I have committed it.  I know that Bruce habitually does
>> this, but I've never found it very helpful, since I prefer to look at
>> the patch either using the pgsql-committers emails or the git
>> respository.
>
> I quite agree --- people who want to read the committed patch are going
> to go to the source, not to what somebody claims he committed.

Yeah, +1. I always go to one of the other sources (most of the time,
the gitweb or git server).

It doesn't hurt to attach it if it happens to be around, but I
wouldn't suggest spending any extra effort on it...
-- Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/


pgsql-hackers by date:

Previous
From: Korry Douglas
Date:
Subject: Re: Why does TRIM() expect an expr_list?
Next
From: Bruce Momjian
Date:
Subject: Re: should I post the patch as committed?