Re: Naming of new tsvector functions - Mailing list pgsql-hackers

From Gavin Flower
Subject Re: Naming of new tsvector functions
Date
Msg-id fcb28372-1cc2-0062-d892-713434805d50@archidevsys.co.nz
Whole thread Raw
In response to Re: Naming of new tsvector functions  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Naming of new tsvector functions  (Stas Kelvich <s.kelvich@postgrespro.ru>)
List pgsql-hackers
On 06/05/16 07:44, Tom Lane wrote:
> Stas Kelvich <s.kelvich@postgrespro.ru> writes:
>>> On 04 May 2016, at 20:15, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Also, I'd supposed that we'd rename to tsvector_something, since
>>> the same patch also introduced tsvector_to_array() and
>>> array_to_tsvector().  What's the motivation for using ts_ as the
>>> prefix?
>> There is already several functions named ts_* (ts_rank, ts_headline, ts_rewrite)
>> and two named starting from tsvector_* (tsvector_update_trigger, tsvector_update_trigger_column).
>> Personally I’d prefer ts_ over tsvector_ since it is shorter, and still keeps semantics.
> Yeah, I see we're already a bit inconsistent here.  The problem with using
> a ts_ prefix, to my mind, is that it offers no option for distinguishing
> tsvector from tsquery, should you need to do that.  Maybe this isn't a
> problem for functions that have tsvector as input.
>
>             regards, tom lane
>
>
use tsv_ and tsq_?


Cheers,
Gavin




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Poorly-thought-out handling of double variables in pgbench
Next
From: Tom Lane
Date:
Subject: Re: Is pg_control file crashsafe?