Re: Naming of new tsvector functions - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Naming of new tsvector functions
Date
Msg-id 10331.1462477476@sss.pgh.pa.us
Whole thread Raw
In response to Re: Naming of new tsvector functions  (Stas Kelvich <s.kelvich@postgrespro.ru>)
Responses Re: Naming of new tsvector functions
List pgsql-hackers
Stas Kelvich <s.kelvich@postgrespro.ru> writes:
>> On 04 May 2016, at 20:15, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Also, I'd supposed that we'd rename to tsvector_something, since
>> the same patch also introduced tsvector_to_array() and
>> array_to_tsvector().  What's the motivation for using ts_ as the
>> prefix?

> There is already several functions named ts_* (ts_rank, ts_headline, ts_rewrite) 
> and two named starting from tsvector_* (tsvector_update_trigger, tsvector_update_trigger_column).

> Personally I’d prefer ts_ over tsvector_ since it is shorter, and still keeps semantics.

Yeah, I see we're already a bit inconsistent here.  The problem with using
a ts_ prefix, to my mind, is that it offers no option for distinguishing
tsvector from tsquery, should you need to do that.  Maybe this isn't a
problem for functions that have tsvector as input.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Teodor Sigaev
Date:
Subject: Re: atomic pin/unpin causing errors
Next
From: Tom Lane
Date:
Subject: Re: quickdie doing memory allocations (was atomic pin/unpin causing errors)