Re: CompilerWarnings task does not catch C++ warnings - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: CompilerWarnings task does not catch C++ warnings
Date
Msg-id f6fcffc6-aded-453f-baab-7beb9e1deb1a@eisentraut.org
Whole thread Raw
In response to Re: CompilerWarnings task does not catch C++ warnings  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 18.06.24 16:08, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> The CompilerWarnings task on Cirrus CI does not catch warnings in C++
>> code.  It tries to make warnings fatal by passing COPT='-Werror', but
>> that does not apply to C++ compilations.
>> I suggest that we just add COPT to CXXFLAGS as well.  I think passing
>> -Werror is just about the only reasonable use of COPT nowadays, so
>> making that more robust seems useful.  I don't think there is a need for
>> a separate make variable for C++ here.
> 
> +1, but what about the meson side of things?

If you use meson {setup|configure} --werror, that would affect both C 
and C++ compilers.




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: may be a buffer overflow problem
Next
From: Ashutosh Sharma
Date:
Subject: Re: Truncation of mapped catalogs (whether local or shared) leads to server crash