Re: CompilerWarnings task does not catch C++ warnings - Mailing list pgsql-hackers

From Tom Lane
Subject Re: CompilerWarnings task does not catch C++ warnings
Date
Msg-id 3595843.1718719691@sss.pgh.pa.us
Whole thread Raw
In response to CompilerWarnings task does not catch C++ warnings  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: CompilerWarnings task does not catch C++ warnings
List pgsql-hackers
Peter Eisentraut <peter@eisentraut.org> writes:
> The CompilerWarnings task on Cirrus CI does not catch warnings in C++ 
> code.  It tries to make warnings fatal by passing COPT='-Werror', but 
> that does not apply to C++ compilations.
> I suggest that we just add COPT to CXXFLAGS as well.  I think passing 
> -Werror is just about the only reasonable use of COPT nowadays, so 
> making that more robust seems useful.  I don't think there is a need for 
> a separate make variable for C++ here.

+1, but what about the meson side of things?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Dave Page
Date:
Subject: Meson far from ready on Windows
Next
From: Andres Freund
Date:
Subject: Re: may be a buffer overflow problem