Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX. - Mailing list pgsql-hackers

From David Steele
Subject Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX.
Date
Msg-id ef0dbb86-511d-94a0-de54-ce526c505a4a@pgmasters.net
Whole thread Raw
In response to Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX.  (James Hilliard <james.hilliard1@gmail.com>)
Responses Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX.  (James Hilliard <james.hilliard1@gmail.com>)
List pgsql-hackers
Hi James,

On 1/31/21 1:59 AM, James Hilliard wrote:
> On Fri, Jan 22, 2021 at 12:32 PM James Hilliard
> <james.hilliard1@gmail.com> wrote:
>>
>> Fixes:
>> gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels
-Wmissing-format-attribute-Wformat-security -fno-strict-aliasing -fwrapv -Wno-unused-command-line-argument -O2
-I../../../../src/include -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk   -c -o fd.o fd.c
 
>> fd.c:3661:10: warning: 'pwritev' is only available on macOS 11.0 or newer [-Wunguarded-availability-new]
>>                  part = pg_pwritev(fd, iov, iovcnt, offset);
>>                         ^~~~~~~~~~

It would be better to provide this patch as an attachment so the cfbot 
(http://commitfest.cputube.org/) can test it.

Regards,
-- 
-David
david@pgmasters.net



pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: [PATCH] Provide more information to filter_prepare
Next
From: Arne Roland
Date:
Subject: Re: Rename of triggers for partitioned tables