Re: [PATCH] Provide more information to filter_prepare - Mailing list pgsql-hackers

From vignesh C
Subject Re: [PATCH] Provide more information to filter_prepare
Date
Msg-id CALDaNm090UzuJjR6ZFFitd1+69NAOx9LqLaMVk_O+rg1Tvjpyw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Provide more information to filter_prepare  (Markus Wanner <markus.wanner@enterprisedb.com>)
List pgsql-hackers
On Mon, Mar 29, 2021 at 5:40 PM Markus Wanner
<markus.wanner@enterprisedb.com> wrote:
>
> On 29.03.21 14:00, vignesh C wrote:
> > Have you intentionally not
> > written any tests as it will be difficult to predict the xid. I just
> > wanted to confirm my understanding.
>
> Yeah, that's the reason this is hard to test this with a regression
> test.  It might be possible to come up with a TAP test for this, but I
> doubt that's worth it, as it's a pretty trivial addition.
>

Thanks, I don't have any more comments.

Regards,
Vignesh



pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: parallel distinct union and aggregate support patch
Next
From: David Steele
Date:
Subject: Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX.