Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX. - Mailing list pgsql-hackers

From James Hilliard
Subject Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX.
Date
Msg-id CADvTj4qwmJgqWB5zStrPAxRL2DsPThtwOubAAUPUSh0XSY0JTw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX.  (David Steele <david@pgmasters.net>)
Responses Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX.  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
Should it work if I just attach it to the thread like this?

On Mon, Mar 29, 2021 at 7:52 AM David Steele <david@pgmasters.net> wrote:
>
> Hi James,
>
> On 1/31/21 1:59 AM, James Hilliard wrote:
> > On Fri, Jan 22, 2021 at 12:32 PM James Hilliard
> > <james.hilliard1@gmail.com> wrote:
> >>
> >> Fixes:
> >> gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels
-Wmissing-format-attribute-Wformat-security -fno-strict-aliasing -fwrapv -Wno-unused-command-line-argument -O2
-I../../../../src/include -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk   -c -o fd.o fd.c 
> >> fd.c:3661:10: warning: 'pwritev' is only available on macOS 11.0 or newer [-Wunguarded-availability-new]
> >>                  part = pg_pwritev(fd, iov, iovcnt, offset);
> >>                         ^~~~~~~~~~
>
> It would be better to provide this patch as an attachment so the cfbot
> (http://commitfest.cputube.org/) can test it.
>
> Regards,
> --
> -David
> david@pgmasters.net

Attachment

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Get memory contexts of an arbitrary backend process
Next
From: Andres Freund
Date:
Subject: Re: Getting better results from valgrind leak tracking