Re: Amcheck verification of GiST and GIN - Mailing list pgsql-hackers

From Jose Arthur Benetasso Villanova
Subject Re: Amcheck verification of GiST and GIN
Date
Msg-id cfa33a8e-de58-d5f1-7020-d0f01571a49d@benetasso.com
Whole thread Raw
In response to Re: Amcheck verification of GiST and GIN  (Andrey Borodin <amborodin86@gmail.com>)
Responses Re: Amcheck verification of GiST and GIN  (Robert Haas <robertmhaas@gmail.com>)
Re: Amcheck verification of GiST and GIN  (Andrey Borodin <amborodin86@gmail.com>)
List pgsql-hackers
On Sun, 27 Nov 2022, Andrey Borodin wrote:

> On Sun, Nov 27, 2022 at 1:29 PM Andrey Borodin <amborodin86@gmail.com> wrote:
>>
> I was wrong. GIN check does similar gin_refind_parent() to lock pages
> in bottom-up manner and truly verify downlink-child_page invariant.

Does this mean that we need the adjustment in docs?

> Here's v17. The only difference is that I added progress reporting to
> GiST verification.
> I still did not implement heapallindexed for GIN. Existence of pending
> lists makes this just too difficult for a weekend coding project :(
>
> Thank you!
>
> Best regards, Andrey Borodin.
>

I'm a bit lost here. I tried your patch again and indeed the 
heapallindexed inside gin_check_parent_keys_consistency has a TODO 
comment, but it's unclear to me if you are going to implement it or if the 
patch "needs review". Right now it's "Waiting on Author".

-- 
Jose Arthur Benetasso Villanova




pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Force streaming every change in logical decoding
Next
From: Amul Sul
Date:
Subject: Re: Error-safe user functions