Re: Amcheck verification of GiST and GIN - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: Amcheck verification of GiST and GIN
Date
Msg-id CAAhFRxj5+7+38LeQe3v9EaQzXFDnu_p_PVrrOMg4fSPEy3CNDA@mail.gmail.com
Whole thread Raw
In response to Re: Amcheck verification of GiST and GIN  (Andrey Borodin <amborodin86@gmail.com>)
Responses Re: Amcheck verification of GiST and GIN
List pgsql-hackers
On Sun, Nov 27, 2022 at 1:29 PM Andrey Borodin <amborodin86@gmail.com> wrote:
>
> GiST verification checks only one invariant that can be verified if
> page locks acquired the same way as page split does.
> GIN does not require ShareLock because it does not check cross-level invariants.
>

I was wrong. GIN check does similar gin_refind_parent() to lock pages
in bottom-up manner and truly verify downlink-child_page invariant.

Here's v17. The only difference is that I added progress reporting to
GiST verification.
I still did not implement heapallindexed for GIN. Existence of pending
lists makes this just too difficult for a weekend coding project :(

Thank you!

Best regards, Andrey Borodin.

Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Bug in row_number() optimization
Next
From: Michael Paquier
Date:
Subject: Re: Allow file inclusion in pg_hba and pg_ident files