Re: Useless parameter 'cur_skey' in IndexScanOK - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Useless parameter 'cur_skey' in IndexScanOK
Date
Msg-id c7f54813-a816-4584-9040-0dea91fdbb4c@iki.fi
Whole thread Raw
In response to Re: Useless parameter 'cur_skey' in IndexScanOK  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On 03/07/2024 16:46, Daniel Gustafsson wrote:
>> On 3 Jul 2024, at 15:41, Aleksander Alekseev <aleksander@timescale.com> wrote:
>>> The 'cur_skey' parameter in `IndexScanOK` funciton doesn't seem to be useful.
> 
>> Good catch. As I understand it is not used for anything since
>> a78fcfb51243 (dated 2006) and this is a static function, so we
>> shouldn't worry about third-party extensions.
> 
> Agreed, it seems reasonable to clean this up.
> 
>> I wonder why none of the compilers complained about this.
> 
> Not to mention static analyzers.

Committed, thanks.

-- 
Heikki Linnakangas
Neon (https://neon.tech)




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [PATCH] Add get_bytes() and set_bytes() functions
Next
From: Yugo Nagata
Date:
Subject: Re: [PATCH] Add get_bytes() and set_bytes() functions