Re: Useless parameter 'cur_skey' in IndexScanOK - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Useless parameter 'cur_skey' in IndexScanOK
Date
Msg-id 603E44BD-A1F3-493C-A904-57170A6DF257@yesql.se
Whole thread Raw
In response to Re: Useless parameter 'cur_skey' in IndexScanOK  (Aleksander Alekseev <aleksander@timescale.com>)
List pgsql-hackers
> On 3 Jul 2024, at 15:41, Aleksander Alekseev <aleksander@timescale.com> wrote:
>> The 'cur_skey' parameter in `IndexScanOK` funciton doesn't seem to be useful.

> Good catch. As I understand it is not used for anything since
> a78fcfb51243 (dated 2006) and this is a static function, so we
> shouldn't worry about third-party extensions.

Agreed, it seems reasonable to clean this up.

> I wonder why none of the compilers complained about this.

Not to mention static analyzers.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pg_wal_summary_contents() and pg_walsummary may return different results on the same WAL summary file
Next
From: "Joel Jacobson"
Date:
Subject: Re: Optimize numeric multiplication for one and two base-NBASE digit multiplicands.