On Mon, Jul 21, 2025 at 03:20:55PM -0500, Nathan Bossart wrote:
> On Fri, Jul 18, 2025 at 01:39:15PM +0000, Bertrand Drouvot wrote:
>> +#define PG_BUILTIN_LWTRANCHE(id, name) [id] = name,
>> +#include "storage/lwlocktranchelist.h"
>> +#undef PG_BUILTIN_LWTRANCHE
>
> Why not reuse PG_LWLOCK for this?
>
>> + # Stop recording if we reach another section.
>> + last if /^Section:/;
>
> Can we add a note to wait_event_names.txt about the required
> ordering/matching of the non-predefined LWLocks? Otherwise, these patches
> look pretty good to me.
Something else I just thought of: could we remove the list of built-in
tranches in lwlock.h with some macro magic that generates it from
lwlocktranchelist.h, too?
--
nathan
