Re: Verify predefined LWLocks tranches have entries in wait_event_names.txt - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Verify predefined LWLocks tranches have entries in wait_event_names.txt
Date
Msg-id aH6hJ77umXAl9-Ft@nathan
Whole thread Raw
In response to Verify predefined LWLocks tranches have entries in wait_event_names.txt  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
Responses Re: Verify predefined LWLocks tranches have entries in wait_event_names.txt
Re: Verify predefined LWLocks tranches have entries in wait_event_names.txt
List pgsql-hackers
On Fri, Jul 18, 2025 at 01:39:15PM +0000, Bertrand Drouvot wrote:
> +#define PG_BUILTIN_LWTRANCHE(id, name) [id] = name,
> +#include "storage/lwlocktranchelist.h"
> +#undef PG_BUILTIN_LWTRANCHE

Why not reuse PG_LWLOCK for this?

> +    # Stop recording if we reach another section.
> +    last if /^Section:/;

Can we add a note to wait_event_names.txt about the required
ordering/matching of the non-predefined LWLocks?  Otherwise, these patches
look pretty good to me.

-- 
nathan



pgsql-hackers by date:

Previous
From: Vik Fearing
Date:
Subject: Re: Proposal: QUALIFY clause
Next
From: Vik Fearing
Date:
Subject: Re: Proposal: QUALIFY clause