Re: Improve readability by using designated initializers when possible - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Improve readability by using designated initializers when possible
Date
Msg-id ZeqgQbe3ySMh-2NB@paquier.xyz
Whole thread Raw
In response to Re: Improve readability by using designated initializers when possible  (Japin Li <japinli@hotmail.com>)
Responses Re: Improve readability by using designated initializers when possible
List pgsql-hackers
On Wed, Mar 06, 2024 at 08:24:09AM +0800, Japin Li wrote:
> On Wed, 06 Mar 2024 at 01:53, Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
>> I think if you remove the EEO_CASE(EEOP_LAST) block the warning should
>> go away. That block is clearly marked as unreachable, so it doesn't
>> really serve a purpose.
>
> Thanks! Fixed as you suggested.  Please see v3 patch.

Hmm.  I am not sure if this one is a good idea.  This makes the code a
bit more complicated to grasp under EEO_USE_COMPUTED_GOTO with the
reverse dispatch table, to say the least.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amul Sul
Date:
Subject: Re: Add system identifier to backup manifest
Next
From: Yugo NAGATA
Date:
Subject: Re: Remove unnecessary code from psql's watch command