Re: Improve readability by using designated initializers when possible - Mailing list pgsql-hackers

From Japin Li
Subject Re: Improve readability by using designated initializers when possible
Date
Msg-id ME3P282MB316608ABA3F6E4D71A74C72EB6212@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM
Whole thread Raw
In response to Re: Improve readability by using designated initializers when possible  (Jelte Fennema-Nio <postgres@jeltef.nl>)
Responses Re: Improve readability by using designated initializers when possible
List pgsql-hackers
On Wed, 06 Mar 2024 at 01:53, Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
> On Tue, 5 Mar 2024 at 15:30, Japin Li <japinli@hotmail.com> wrote:
>> There is a warning if remove it, so I keep it.
>>
>> /home/japin/Codes/postgres/build/../src/backend/executor/execExprInterp.c:118:33: warning: label ‘CASE_EEOP_LAST’
definedbut not used [-Wunused-label] 
>>   118 | #define EEO_CASE(name)          CASE_##name:
>>       |                                 ^~~~~
>> /home/japin/Codes/postgres/build/../src/backend/executor/execExprInterp.c:1845:17: note: in expansion of macro
‘EEO_CASE’
>>  1845 |                 EEO_CASE(EEOP_LAST)
>>       |                 ^~~~~~~~
>
> I think if you remove the EEO_CASE(EEOP_LAST) block the warning should
> go away. That block is clearly marked as unreachable, so it doesn't
> really serve a purpose.

Thanks! Fixed as you suggested.  Please see v3 patch.


Attachment

pgsql-hackers by date:

Previous
From: David Zhang
Date:
Subject: Re: Proposal for implementing OCSP Stapling in PostgreSQL
Next
From: Peter Geoghegan
Date:
Subject: Re: Optimizing nbtree ScalarArrayOp execution, allowing multi-column ordered scans, skip scan