Postgres Pro
Downloads
Home   >   mailing lists

Re: Improve readability by using designated initializers when possible - Mailing list pgsql-hackers

From Jelte Fennema-Nio
Subject Re: Improve readability by using designated initializers when possible
Date
Msg-id CAGECzQQjQSJ3-bahHv8p7R3SCxyw=g7M0=+CJN5FmktC7hJZog@mail.gmail.com
Whole thread Raw
In response to Re: Improve readability by using designated initializers when possible  (Japin Li <japinli@hotmail.com>)
Responses Re: Improve readability by using designated initializers when possible
List pgsql-hackers
Tree view 
On Tue, 5 Mar 2024 at 15:30, Japin Li <japinli@hotmail.com> wrote:
> There is a warning if remove it, so I keep it.
>
> /home/japin/Codes/postgres/build/../src/backend/executor/execExprInterp.c:118:33: warning: label ‘CASE_EEOP_LAST’
definedbut not used [-Wunused-label] 
>   118 | #define EEO_CASE(name)          CASE_##name:
>       |                                 ^~~~~
> /home/japin/Codes/postgres/build/../src/backend/executor/execExprInterp.c:1845:17: note: in expansion of macro
‘EEO_CASE’
>  1845 |                 EEO_CASE(EEOP_LAST)
>       |                 ^~~~~~~~

I think if you remove the EEO_CASE(EEOP_LAST) block the warning should
go away. That block is clearly marked as unreachable, so it doesn't
really serve a purpose.

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Dump-restore loosing 'attnotnull' bit for DEFERRABLE PRIMARY KEY column(s).
Next
From: Jeff Davis
Date:
Subject: Re: pgsql: Fix search_path to a safe value during maintenance operations.