Re: Improve readability by using designated initializers when possible - Mailing list pgsql-hackers

From Japin Li
Subject Re: Improve readability by using designated initializers when possible
Date
Msg-id ME3P282MB31669EF949EE5EE93C45161CB62B2@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM
Whole thread Raw
In response to Re: Improve readability by using designated initializers when possible  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Fri, 08 Mar 2024 at 13:21, Michael Paquier <michael@paquier.xyz> wrote:
> On Wed, Mar 06, 2024 at 08:24:09AM +0800, Japin Li wrote:
>> On Wed, 06 Mar 2024 at 01:53, Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
>>> I think if you remove the EEO_CASE(EEOP_LAST) block the warning should
>>> go away. That block is clearly marked as unreachable, so it doesn't
>>> really serve a purpose.
>>
>> Thanks! Fixed as you suggested.  Please see v3 patch.
>
> Hmm.  I am not sure if this one is a good idea.

Sorry for the late reply!

> This makes the code a
> bit more complicated to grasp under EEO_USE_COMPUTED_GOTO with the
> reverse dispatch table, to say the least.

I'm not get your mind.  Could you explain in more detail?



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Using the %m printf format more
Next
From: Nathan Bossart
Date:
Subject: Re: Popcount optimization using AVX512