Re: Reconcile stats in find_tabstat_entry() and get rid of PgStat_BackendFunctionEntry - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Reconcile stats in find_tabstat_entry() and get rid of PgStat_BackendFunctionEntry
Date
Msg-id ZBpW3NLVT8ygnQp7@paquier.xyz
Whole thread Raw
In response to Re: Reconcile stats in find_tabstat_entry() and get rid of PgStat_BackendFunctionEntry  ("Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>)
Responses Re: Reconcile stats in find_tabstat_entry() and get rid of PgStat_BackendFunctionEntry  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers
On Mon, Mar 20, 2023 at 11:57:31AM +0100, Drouvot, Bertrand wrote:
> "Buffer" sounds more appropriate to me, so the attached has been done that way.

This choice is OK for me.

> +        <indexterm>
> +         <primary>pg_stat_get_xact_blocks_fetched</primary>
> +        </indexterm>
> +        <function>pg_stat_get_xact_blocks_fetched</function> ( <type>oid</type> )
> +        <returnvalue>bigint</returnvalue>
> +       </para>
> +       <para>
> +        Returns the number of buffer fetches for table or index, in the current transaction

This should be "number of buffer fetched", no?

> +        </indexterm>
> +        <function>pg_stat_get_xact_blocks_hit</function> ( <type>oid</type> )
> +        <returnvalue>bigint</returnvalue>
> +       </para>
> +       <para>
> +        Returns the number of buffer hits for table or index, in the current transaction
> +       </para></entry>

This one looks OK to me too.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Melanie Plageman
Date:
Subject: Re: Track IO times in pg_stat_io
Next
From: Michael Paquier
Date:
Subject: Re: Remove nonmeaningful prefixes in PgStat_* fields