Re: add checkpoint stats of snapshot and mapping files of pg_logical dir - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: add checkpoint stats of snapshot and mapping files of pg_logical dir
Date
Msg-id YwWqbjN1IHaBlQOb@paquier.xyz
Whole thread Raw
In response to Re: add checkpoint stats of snapshot and mapping files of pg_logical dir  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers
On Wed, Aug 24, 2022 at 10:48:01AM +0900, Kyotaro Horiguchi wrote:
> By the way, I think we use INSTR_TIME_* macros to do masure internal
> durations (mainly for the monotonic clock characteristics, and to
> reduce performance degradation on Windows?). I'm not sure that's
> crutial here but I don't think there's any reason to use
> GetCurrentTimestamp() instead.

This implies two calls of gettimeofday(), but that does not worry me
much in this code path.  There is some consistency with
CheckpointGuts() where we take timestamps for the sync requests.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: ecpg assertion on windows
Next
From: Michael Paquier
Date:
Subject: Re: ICU for global collation