On Tue, Aug 23, 2022 at 08:59:02PM +0300, Marina Polyakova wrote:
> My colleague Andrew Bille found another bug in master
> (b4e936859dc441102eb0b6fb7a104f3948c90490) and REL_15_STABLE
> (2c63b0930aee1bb5c265fad4a65c9d0b62b1f9da): pg_collation.colliculocale is
> not dumped. See check_icu_locale.sh:
>
> In the old cluster:
> SELECT collname, colliculocale FROM pg_collation WHERE collname =
> 'testcoll_backwards'
> collname | colliculocale
> --------------------+-------------------
> testcoll_backwards | @colBackwards=yes
> (1 row)
>
> In the new cluster:
> SELECT collname, colliculocale FROM pg_collation WHERE collname =
> 'testcoll_backwards'
> collname | colliculocale
> --------------------+---------------
> testcoll_backwards |
> (1 row)
>
> diff_dump_colliculocale.patch works for me.
Ugh. Good catch, again! I have not tested the patch in details but
this looks rather sane to me on a quick read. Peter?
--
Michael