Re: suboverflowed subtransactions concurrency performance optimize - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: suboverflowed subtransactions concurrency performance optimize
Date
Msg-id Yk54Y+c6gXfBnaiK@paquier.xyz
Whole thread Raw
In response to Re: suboverflowed subtransactions concurrency performance optimize  (Julien Rouhaud <rjuju123@gmail.com>)
Responses Re: suboverflowed subtransactions concurrency performance optimize  (Simon Riggs <simon.riggs@enterprisedb.com>)
Re: suboverflowed subtransactions concurrency performance optimize  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Mon, Mar 07, 2022 at 10:17:41PM +0800, Julien Rouhaud wrote:
> On Mon, Mar 07, 2022 at 01:27:40PM +0000, Simon Riggs wrote:
>> The patch was posted because TransactionLogFetch() has a cache, yet
>> SubTransGetTopmostTransaction() does not, yet the argument should be
>> identical in both cases.
>
> I totally agree with that.

Agreed as well.  That's worth doing in isolation and that will save
some lookups of pg_subtrans anyway while being simple.  As mentioned
upthread, this needed an indentation, and the renaming of
cachedFetchXid to cachedFetchSubXid looks adapted.  So..  Applied all
those things.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Logical replication timeout problem
Next
From: Michael Paquier
Date:
Subject: Re: Change the csv log to 'key:value' to facilitate the user to understanding and processing of logs