Re: suboverflowed subtransactions concurrency performance optimize - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: suboverflowed subtransactions concurrency performance optimize
Date
Msg-id CANbhV-GeqH6v__ssSbTNcL9LAe1REn_H-_dzF7ze+TKAOwYvTQ@mail.gmail.com
Whole thread Raw
In response to Re: suboverflowed subtransactions concurrency performance optimize  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Thu, 7 Apr 2022 at 00:36, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Mon, Mar 07, 2022 at 10:17:41PM +0800, Julien Rouhaud wrote:
> > On Mon, Mar 07, 2022 at 01:27:40PM +0000, Simon Riggs wrote:
> >> The patch was posted because TransactionLogFetch() has a cache, yet
> >> SubTransGetTopmostTransaction() does not, yet the argument should be
> >> identical in both cases.
> >
> > I totally agree with that.
>
> Agreed as well.  That's worth doing in isolation and that will save
> some lookups of pg_subtrans anyway while being simple.  As mentioned
> upthread, this needed an indentation, and the renaming of
> cachedFetchXid to cachedFetchSubXid looks adapted.  So..  Applied all
> those things.

Thanks Michael, thanks all.

-- 
Simon Riggs                http://www.EnterpriseDB.com/



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Can we automatically add elapsed times to tap test log?
Next
From: Pavel Stehule
Date:
Subject: Re: Schema variables - new implementation for Postgres 15