Re: pg_stat_get_replication_slot and pg_stat_get_subscription_worker incorrectly marked as proretset - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_stat_get_replication_slot and pg_stat_get_subscription_worker incorrectly marked as proretset
Date
Msg-id YhROWPYHo9itaj5s@paquier.xyz
Whole thread Raw
In response to Re: pg_stat_get_replication_slot and pg_stat_get_subscription_worker incorrectly marked as proretset  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: pg_stat_get_replication_slot and pg_stat_get_subscription_worker incorrectly marked as proretset  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Mon, Feb 21, 2022 at 05:00:43PM +0530, Amit Kapila wrote:
> On Mon, Feb 21, 2022 at 4:56 PM Michael Paquier <michael@paquier.xyz> wrote:
>> That's the same thing as what I sent upthread, so that's correct to
>> me, except that I have fixed both functions :)
>
> Sorry, I hadn't looked at your patch.

That's fine.  This is something you have committed, after all.

>> You are not touching pg_stat_get_subscription_worker() because the
>> plan is to revert it from HEAD?  I have not followed the other
>> discussion closely.
>>
>
> It is still under discussion. I'll take the necessary action along
> with other things related to that view based on the conclusion on that
> thread.

Sounds good to me.  The patch you are proposing upthread is OK for
me.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: shared_preload_libraries = 'pg_stat_statements' failing with installcheck (compute_query_id = auto)
Next
From: "kuroda.hayato@fujitsu.com"
Date:
Subject: RE: [Proposal] Add foreign-server health checks infrastructure