Postgres Pro
Downloads
Home   >   mailing lists

Re: Possible uninitialized use of the variables (src/backend/access/transam/twophase.c) - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Possible uninitialized use of the variables (src/backend/access/transam/twophase.c)
Date
Msg-id Ygm5V91SwQPenkFn@paquier.xyz
Whole thread Raw
In response to Re: Possible uninitialized use of the variables (src/backend/access/transam/twophase.c)  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Possible uninitialized use of the variables (src/backend/access/transam/twophase.c)  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Re: Possible uninitialized use of the variables (src/backend/access/transam/twophase.c)  (Ranier Vilela <ranier.vf@gmail.com>)
List pgsql-hackers
Tree view 
On Thu, Feb 10, 2022 at 11:38:44AM +0900, Michael Paquier wrote:
> The proposed change is incomplete anyway once you consider this
> argument.  First, there is no need to set up those fields in
> EndPrepare() anymore if there is no origin data, no?  It would be good
> to comment that these are filled in EndPrepare(), I guess, once you do
> the initialization in StartPrepare().

That still looked better on a fresh look in terms of consistency, so
applied this way.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc
Next
From: Thomas Munro
Date:
Subject: Re: buildfarm warnings