Postgres Pro
Downloads
Home   >   mailing lists

Re: Possible uninitialized use of the variables (src/backend/access/transam/twophase.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: Possible uninitialized use of the variables (src/backend/access/transam/twophase.c)
Date
Msg-id CAEudQAquHvoMPAr0JgxP5QBiB+cUJe0wCV92jw-NitG+hZWgEQ@mail.gmail.com
Whole thread Raw
In response to Re: Possible uninitialized use of the variables (src/backend/access/transam/twophase.c)  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view
Em dom., 13 de fev. de 2022 às 23:07, Michael Paquier <michael@paquier.xyz> escreveu:
On Thu, Feb 10, 2022 at 11:38:44AM +0900, Michael Paquier wrote:
> The proposed change is incomplete anyway once you consider this
> argument.  First, there is no need to set up those fields in
> EndPrepare() anymore if there is no origin data, no?  It would be good
> to comment that these are filled in EndPrepare(), I guess, once you do
> the initialization in StartPrepare().

That still looked better on a fresh look in terms of consistency, so
applied this way.
Thanks.

regards,
Ranier Vilela

pgsql-hackers by date:

Previous
From: Frédéric Yhuel
Date:
Subject: Re: Allow parallel plan for referential integrity checks?
Next
From: Amit Kapila
Date:
Subject: Re: Optionally automatically disable logical replication subscriptions on error