Re: Report roles in pg_upgrade pg_ prefix check - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Report roles in pg_upgrade pg_ prefix check
Date
Msg-id Y4EjcmIl+IGBa5J+@momjian.us
Whole thread Raw
In response to Report roles in pg_upgrade pg_ prefix check  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On Thu, Nov 24, 2022 at 12:31:09PM +0100, Daniel Gustafsson wrote:
> Looking at a recent pg_upgrade thread I happened to notice that the check for
> roles with a pg_ prefix only reports the error, not the roles it found.  Other
> similar checks where the user is expected to alter the old cluster typically
> reports the found objects in a textfile.  The attached adds reporting to make
> that class of checks consistent (the check for prepared transactions which also
> isn't reporting is different IMO as it doesn't expect ALTER commands).
> 
> As this check is only executed against the old cluster the patch removes the
> check when printing the error.

+1

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

Embrace your flaws.  They make you human, rather than perfect,
which you will never be.



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Fix for visibility check on 14.5 fails on tpcc with high concurrency
Next
From: Pavel Borisov
Date:
Subject: Re: Use fadvise in wal replay