Report roles in pg_upgrade pg_ prefix check - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Report roles in pg_upgrade pg_ prefix check
Date
Msg-id 4BB2735C-C347-4CF7-AFB1-8573BE930066@yesql.se
Whole thread Raw
Responses Re: Report roles in pg_upgrade pg_ prefix check
Re: Report roles in pg_upgrade pg_ prefix check
List pgsql-hackers
Looking at a recent pg_upgrade thread I happened to notice that the check for
roles with a pg_ prefix only reports the error, not the roles it found.  Other
similar checks where the user is expected to alter the old cluster typically
reports the found objects in a textfile.  The attached adds reporting to make
that class of checks consistent (the check for prepared transactions which also
isn't reporting is different IMO as it doesn't expect ALTER commands).

As this check is only executed against the old cluster the patch removes the
check when printing the error.

--
Daniel Gustafsson        https://vmware.com/


Attachment

pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: postgres_fdw: batch inserts vs. before row triggers
Next
From: Sergey Shinderuk
Date:
Subject: Re: Bug in row_number() optimization