Re: New "single-call SRF" APIs are very confusingly named - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: New "single-call SRF" APIs are very confusingly named
Date
Msg-id Y0odxEuRbPeFVEkA@paquier.xyz
Whole thread Raw
In response to Re: New "single-call SRF" APIs are very confusingly named  (Melanie Plageman <melanieplageman@gmail.com>)
Responses Re: New "single-call SRF" APIs are very confusingly named  (Melanie Plageman <melanieplageman@gmail.com>)
Re: New "single-call SRF" APIs are very confusingly named  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Fri, Oct 14, 2022 at 05:09:46PM -0400, Melanie Plageman wrote:
> To summarize, I am in support of renaming SetSingleFuncCall() ->
> InitMaterializedSRF() and SRF_SINGLE_USE_EXPECTED ->
> MAT_SRF_USE_EXPECTED_TUPLE_DESC (or just DESC) as suggested elsewhere in
> this thread. And I think we should eventually consider renaming the
> multi* function names and consider if ExprSingleResult is a good name.

As already mentioned, these have been around for years, so the impact
would be bigger.  Attached is a patch for HEAD and REL_15_STABLE to
switch this stuff with new names, with what's needed for ABI
compatibility.  My plan would be to keep the compatibility parts only
in 15, and drop them from HEAD.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: make_ctags: use -I option to ignore pg_node_attr macro
Next
From: Michael Paquier
Date:
Subject: Re: Add regular expression testing for user name mapping in the peer authentication TAP test