Re: Add regular expression testing for user name mapping in the peer authentication TAP test - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Add regular expression testing for user name mapping in the peer authentication TAP test
Date
Msg-id Y0ok4AzB1XcYtzd5@paquier.xyz
Whole thread Raw
In response to Add regular expression testing for user name mapping in the peer authentication TAP test  ("Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>)
Responses Re: Add regular expression testing for user name mapping in the peer authentication TAP test  ("Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>)
List pgsql-hackers
On Fri, Oct 14, 2022 at 06:31:15PM +0200, Drouvot, Bertrand wrote:
> while working on [1], I thought it could also be useful to add regular
> expression testing for user name mapping in the peer authentication TAP
> test.

Good idea now that we have a bit more coverage in the authentication
tests.

> +# Test with regular expression in user name map.
> +my $last_system_user_char = substr($system_user, -1);

This would attach to the regex the last character of the system user.
I would perhaps have used more characters than that (-3?), as substr()
with a negative number larger than the string given in input would
give the entire string.  That's a nit, though.

> +# The regular expression does not match.
> +reset_pg_ident($node, 'mypeermap', '/^$', 'testmapuser');

This matches only an empty string, my brain gets that right?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: New "single-call SRF" APIs are very confusingly named
Next
From: Bharath Rupireddy
Date:
Subject: Re: thinko in basic_archive.c