Re: build fixes - Mailing list pgsql-patches

From Peter Eisentraut
Subject Re: build fixes
Date
Msg-id Pine.LNX.4.30.0108211744200.856-100000@peter.localdomain
Whole thread Raw
In response to build fixes  (Liam Stewart <liams@redhat.com>)
Responses Re: build fixes  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Liam Stewart writes:

> Here is a patch that fixes a couple of dumb bugs that cause builds to
> fail.

>                 snprintf(PQerrormsg, PQERRORMSG_LENGTH,
> !                        "ident_unix: unknown local user with uid %d\n"),
>                 fputs(PQerrormsg, stderr);

We generally put semicolons at the end in C. ;-)

>         /* descriptor items */
>         enum ECPGdtype
>         {
> !               ECPGd_count = 1,
>                 ECPGd_data,
>                 ECPGd_di_code,
>                 ECPGd_di_precision,
> --- 52,59 ----
>         /* descriptor items */
>         enum ECPGdtype
>         {
> !               ECPGd_cardinality = 1,
> !               ECPGd_count,
>                 ECPGd_data,
>                 ECPGd_di_code,
>                 ECPGd_di_precision,

Put it at the end unless you want to deal with binary incompatibilities.

--
Peter Eisentraut   peter_e@gmx.net   http://funkturm.homeip.net/~peter


pgsql-patches by date:

Previous
From: Liam Stewart
Date:
Subject: Re: build fixes
Next
From: Bruce Momjian
Date:
Subject: Re: build fixes