Re: build fixes - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: build fixes
Date
Msg-id 200108211713.f7LHDJu23225@candle.pha.pa.us
Whole thread Raw
In response to Re: build fixes  (Liam Stewart <liams@redhat.com>)
List pgsql-patches
> On Tue, Aug 21, 2001 at 10:47:41AM -0400, Bruce Momjian wrote:
> > OK, I fixed the first one with:
> >
> >         snprintf(PQerrormsg, PQERRORMSG_LENGTH,
> >              "ident_unix: unknown local user with uid %d\n", peercred.uid);
> >                                                            ^^^^^^^^^^^^^^^
>
> Whoops..you can tell I was just trying to get a clean build..

Great.  No problem.

> > In the following patch, is it correct to make ECPGd_cardinality = 1 or
> > should it be put at the end of the list?
>
> Well, I just maintained the alphabetical ordering there. Unless there's
> code that depends on the specific integer values of the enumerations, it
> shouldn't make a difference. Next time I'll just submit a bug to hackers
> instead of delving into code I don't know all that well.

I found ecpg failing on my machine too.  I put it near the end, just in
case something needs that first entry to be 1.  In fact, they numbered
the first one, which I think means it mean something.  They have some
marker at the end so I wonder is they use that for something too.  I put
it right before the marker at the end.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: build fixes
Next
From: Bruce Momjian
Date:
Subject: Re: build fixes