Re: build fixes - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: build fixes
Date
Msg-id 200108211714.f7LHE3e23435@candle.pha.pa.us
Whole thread Raw
In response to Re: build fixes  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-patches
> Liam Stewart writes:
>
> > Here is a patch that fixes a couple of dumb bugs that cause builds to
> > fail.
>
> >                 snprintf(PQerrormsg, PQERRORMSG_LENGTH,
> > !                        "ident_unix: unknown local user with uid %d\n"),
> >                 fputs(PQerrormsg, stderr);
>
> We generally put semicolons at the end in C. ;-)

Yea, I guess so.  :-)  Actually, we needed a uid parameter which I added
too.


>
> >         /* descriptor items */
> >         enum ECPGdtype
> >         {
> > !               ECPGd_count = 1,
> >                 ECPGd_data,
> >                 ECPGd_di_code,
> >                 ECPGd_di_precision,
> > --- 52,59 ----
> >         /* descriptor items */
> >         enum ECPGdtype
> >         {
> > !               ECPGd_cardinality = 1,
> > !               ECPGd_count,
> >                 ECPGd_data,
> >                 ECPGd_di_code,
> >                 ECPGd_di_precision,
>
> Put it at the end unless you want to deal with binary incompatibilities.

Done.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: build fixes
Next
From: "Greg Zoller"
Date:
Subject: Array Support Fix