Re: fix broken regression tests - Mailing list pgsql-patches

From Gavin Sherry
Subject Re: fix broken regression tests
Date
Msg-id Pine.LNX.4.21.0301160926130.3772-100000@linuxworld.com.au
Whole thread Raw
In response to Re: fix broken regression tests  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: fix broken regression tests
List pgsql-patches
On Wed, 15 Jan 2003, Tom Lane wrote:

> Gavin Sherry <swm@linuxworld.com.au> writes:
> > On Wed, 15 Jan 2003, Tom Lane wrote:
> >> Ugh, that's bad news.  Can we lobby the bison folks to revert this
> >> random rewording of an error message?  Or at least make it configurable,
> >> so that we can avoid exposing any change to our users?
>
> > The change doesn't seem to be for trivial reasons. Log message for
> > revision 1.35 of data/yacc.c says:
> > "parse error" -> "syntax error" for POSIX compatibility.
>
> Grumble.  That probably means they'll reject any complaints about it.

Yep. That's why I brought it up.

>
> My inclination at this point is to do sed 's/syntax error/parse error/'
> in our grammar build rules so as to maintain backwards compatibility.

How about we do that for 7.4 with a mention in the release notes / manual
that 'syntax error' will release 'parse error' in some future
release. Then again, isn't their a planned overhaul of error handling
for 7.4 to bring it into line with SQL? If so, a change to parse error
messages is the smallest problem facing users.

Gavin


pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: implement EXPLAIN EXECUTE
Next
From: Rod Taylor
Date:
Subject: Re: ALTER TABLE .. SET WITHOUT OIDS -- ROUND 2