Re: [HACKERS] Linux/Alpha and pgsql.... - Mailing list pgsql-hackers

From Ryan Kirkpatrick
Subject Re: [HACKERS] Linux/Alpha and pgsql....
Date
Msg-id Pine.LNX.3.95.980411133901.8221A-300000@stargazer
Whole thread Raw
In response to Re: [HACKERS] Linux/Alpha and pgsql....  (Bruce Momjian <maillist@candle.pha.pa.us>)
Responses Re: [HACKERS] Linux/Alpha and pgsql....
Re: [HACKERS] Linux/Alpha and pgsql....
List pgsql-hackers
On Fri, 10 Apr 1998, Bruce Momjian wrote:

> >     Can you grab the latest snapshot, which is going to be v6.3.2, and
> > confirm/tweak your patch with that?  Its meant for release on April 15th,
> > as long as my personal 'show stoppers' are no longer a problem :)
>
> Again, the addition in templates/linuxalpha should fix most of your
> problems.  Let us know.

    Ok, I grabbed the latest snapshot, April 11, 7am. The changes in
templates/linuxalpha do fix some of the problems, and make fixing the rest
easier. As it was "out-of-the-box", it (nearly) compiled and ran initdb
sucessfully on my UDB. But there was quite a few failures and coredumps by
postgres upon the running of regression tests.
    To get it compile succesfully, I had to make sure the linux/alpha
did not include a few .h files that the alpha version was supposed to
include. This occured in ./backend/main/main.c, and the patch for it is
attached.
    I then added -Dlinuxalpha to the ./template/linuxalpha CFLAGS
line, and recompiled. 'initdb' ran fine, and regression tests went much
better. Now about 75% of the regression tests complete successfully. From
the looks of things, floats are still causing most of the problems. I
haven't looked yet to see if there are major problems, or just minor
formatting ones. A patch for the ./template/linuxalpha changes is also
attached.
    These two patches should bring the current version of pgsql very
close to working cleaning on Linux/Alpha! :) As usual, if you have any
questions, feel free to email me.

----------------------------------------------------------------------------
|   "For to me to live is Christ, and to die is gain."                     |
|                                            --- Philippians 1:21 (KJV)    |
----------------------------------------------------------------------------
|  Ryan Kirkpatrick  |  Boulder, Colorado  | rkirkpat@nag.cs.colorado.edu  |
----------------------------------------------------------------------------
|               http://www-ugrad..cs.colorado.edu/~rkirkpat/                |
----------------------------------------------------------------------------
--- pgsql.original/src/template/linuxalpha    Mon Apr  6 02:02:15 1998
+++ pgsql/src/template/linuxalpha    Sat Apr 11 09:42:24 1998
@@ -1,5 +1,5 @@
 AROPT:crs
-CFLAGS:-O2 -Dalpha
+CFLAGS:-O2 -Dalpha -Dlinuxalpha
 SHARED_LIB:-fpic
 ALL:
 SRCH_INC:
--- pgsql.original/src/backend/main/main.c    Mon Mar 23 02:00:35 1998
+++ pgsql/src/backend/main/main.c    Sat Apr 11 08:38:54 1998
@@ -15,7 +15,7 @@
 #include <string.h>
 #include <unistd.h>
 
-#ifdef alpha
+#if defined(alpha) && !defined(linux)
 #include <sys/sysinfo.h>
 #include <machine/hal_sysinfo.h>
 #define ASSEMBLER

pgsql-hackers by date:

Previous
From: The Hermit Hacker
Date:
Subject: Did we ever...
Next
From: The Hermit Hacker
Date:
Subject: Re: [HACKERS] Linux/Alpha and pgsql....