RE: Skipping logical replication transactions on subscriber side - Mailing list pgsql-hackers

On July 29, 2021 1:48 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> 
> Sorry I've attached wrong ones. Reattached the correct version patches.

Hi,

I had some comments on the new version patches.

1)

-       relstate = (SubscriptionRelState *) palloc(sizeof(SubscriptionRelState));
-       relstate->relid = subrel->srrelid;
+       relstate = (SubscriptionRelState *) hash_search(htab, (void *) &subrel->srrelid,
+                                                       HASH_ENTER, NULL);

I found the new version patch changes the List type 'relstate' to hash table type
'relstate'. Will this bring significant performance improvements ?

2)
+ * PgStat_StatSubRelErrEntry represents a error happened during logical

a error => an error

3)
+CREATE VIEW pg_stat_subscription_errors AS
+    SELECT
+   d.datname,
+   sr.subid,
+   s.subname,

It seems the 'subid' column is not mentioned in the document of the
pg_stat_subscription_errors view.


4)
+
+                   if (fread(&nrels, 1, sizeof(long), fpin) != sizeof(long))
+                   {
    ...
+                   for (int i = 0; i < nrels; i++)

the type of i(int) seems different of the type or 'nrels'(long), it might be
better to use the same type.

Best regards,
houzj