On Fri, Jul 30, 2021 at 3:47 PM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:
>
> On July 29, 2021 1:48 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > Sorry I've attached wrong ones. Reattached the correct version patches.
>
> Hi,
>
> I had some comments on the new version patches.
Thank you for the comments!
>
> 1)
>
> - relstate = (SubscriptionRelState *) palloc(sizeof(SubscriptionRelState));
> - relstate->relid = subrel->srrelid;
> + relstate = (SubscriptionRelState *) hash_search(htab, (void *) &subrel->srrelid,
> + HASH_ENTER, NULL);
>
> I found the new version patch changes the List type 'relstate' to hash table type
> 'relstate'. Will this bring significant performance improvements ?
For pgstat_vacuum_stat() purposes, I think it's better to use a hash
table to avoid O(N) lookup. But it might not be good to change the
type of the return value of GetSubscriptionNotReadyRelations() since
this returned value is used by other functions to iterate over
elements. The list iteration is faster than the hash table’s one. It
would be better to change it so that pgstat_vacuum_stat() constructs a
hash table for its own purpose.
>
> 2)
> + * PgStat_StatSubRelErrEntry represents a error happened during logical
>
> a error => an error
Will fix.
>
> 3)
> +CREATE VIEW pg_stat_subscription_errors AS
> + SELECT
> + d.datname,
> + sr.subid,
> + s.subname,
>
> It seems the 'subid' column is not mentioned in the document of the
> pg_stat_subscription_errors view.
Will fix.
>
>
> 4)
> +
> + if (fread(&nrels, 1, sizeof(long), fpin) != sizeof(long))
> + {
> ...
> + for (int i = 0; i < nrels; i++)
>
> the type of i(int) seems different of the type or 'nrels'(long), it might be
> better to use the same type.
Will fix.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
