Re: Identify missing publications from publisher while create/alter subscription. - Mailing list pgsql-hackers

From Japin Li
Subject Re: Identify missing publications from publisher while create/alter subscription.
Date
Msg-id MEYP282MB166933BF96F1D58EBE4A5AB6B6579@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
Whole thread Raw
In response to Re: Identify missing publications from publisher while create/alter subscription.  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
On Thu, 06 May 2021 at 21:52, vignesh C <vignesh21@gmail.com> wrote:
> On Thu, May 6, 2021 at 9:08 AM Japin Li <japinli@hotmail.com> wrote:
>> 3) Should we free the memory when finish the check_publications()?
>> +       publicationsCopy = list_copy(publications);
>
> I felt this list entries will be deleted in the success case, in error
> case I felt no need to delete it as we will be exiting. Thoughts?
>

Sorry for the noise! You are right. The v9 patch set looks good to me.

-- 
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.



pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: Race condition in recovery?
Next
From: Dilip Kumar
Date:
Subject: Re: Identify missing publications from publisher while create/alter subscription.