Postgres Pro
Downloads
Home   >   mailing lists

Re: Identify missing publications from publisher while create/alter subscription. - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: Identify missing publications from publisher while create/alter subscription.
Date
Msg-id CAFiTN-sbNq-1pC4Ji8fjLgF0cR-5b4Jk1BL3UdGZSfccu9ShSg@mail.gmail.com
Whole thread Raw
In response to Re: Identify missing publications from publisher while create/alter subscription.  (vignesh C <vignesh21@gmail.com>)
Responses Re: Identify missing publications from publisher while create/alter subscription.
List pgsql-hackers
Tree view 
On Thu, May 6, 2021 at 7:22 PM vignesh C <vignesh21@gmail.com> wrote:
>

Some comments:
1.
I don't see any change in pg_dump.c, don't we need to dump this option?

2.
+ /* Try to connect to the publisher. */
+ wrconn = walrcv_connect(sub->conninfo, true, sub->name, &err);
+ if (!wrconn)
+ ereport(ERROR,
+ (errmsg("could not connect to the publisher: %s", err)));

Instead of using global wrconn, I think you should use a local variable?

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Japin Li
Date:
Subject: Re: Identify missing publications from publisher while create/alter subscription.
Next
From: "tsunakawa.takay@fujitsu.com"
Date:
Subject: RE: [bug?] Missed parallel safety checks, and wrong parallel safety