pgsql: Convert PageAddItem into a macro to save a few cycles. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Convert PageAddItem into a macro to save a few cycles.
Date
Msg-id E1biU6j-0003Zp-UH@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Convert PageAddItem into a macro to save a few cycles.

Nowadays this is just a backwards-compatibility wrapper around
PageAddItemExtended, so let's avoid the extra level of function call.
In addition, because pretty much all callers are passing constants
for the two bool arguments, compilers will be able to constant-fold
the conversion to a flags bitmask.

Discussion: <552.1473445163@sss.pgh.pa.us>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/1a4be103a523db8d47b464463ba175cc664442b2

Modified Files
--------------
src/backend/storage/page/bufpage.c | 20 --------------------
src/include/storage/bufpage.h      |  7 +++++--
2 files changed, 5 insertions(+), 22 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Invent PageIndexTupleOverwrite, and teach BRIN and GiST to use i
Next
From: Tom Lane
Date:
Subject: pgsql: Rewrite PageIndexDeleteNoCompact into a form that only deletes 1