pgsql: Rewrite PageIndexDeleteNoCompact into a form that only deletes 1 - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Rewrite PageIndexDeleteNoCompact into a form that only deletes 1
Date
Msg-id E1biUnE-0004MI-3S@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Rewrite PageIndexDeleteNoCompact into a form that only deletes 1 tuple.

The full generality of deleting an arbitrary number of tuples is no longer
needed, so let's save some code and cycles by replacing the original coding
with an implementation based on PageIndexTupleDelete.

We can always get back the old code from git if we need it again for new
callers (though I don't care for its willingness to mess with line pointers
it wasn't told to mess with).

Discussion: <552.1473445163@sss.pgh.pa.us>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/24992c6db9fd40f342db1f22747ec9e56483796d

Modified Files
--------------
src/backend/access/brin/brin_pageops.c |   2 +-
src/backend/access/brin/brin_xlog.c    |   4 +-
src/backend/storage/page/bufpage.c     | 194 ++++++++++++---------------------
src/include/storage/bufpage.h          |   3 +-
4 files changed, 74 insertions(+), 129 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Convert PageAddItem into a macro to save a few cycles.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix miserable coding in pg_stat_get_activity().