Replacing TAP test planning with done_testing() - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Replacing TAP test planning with done_testing()
Date
Msg-id DD399313-3D56-4666-8079-88949DAC870F@yesql.se
Whole thread Raw
Responses Re: Replacing TAP test planning with done_testing()  (Julien Rouhaud <rjuju123@gmail.com>)
Re: Replacing TAP test planning with done_testing()  (Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>)
List pgsql-hackers
Whether or not to explicitly plan the number of TAP tests per suite has been
discussed a number of times on this list, often as a side-note in an unrelated
thread which adds/modifies a test.  The concensus has so far weighed towards
not doing manual bookkeeping of test plans but to let Test::More deal with it.
So far, no concrete patch to make that happen has been presented though.

The attached patch removes all Test::More planning and instead ensures that all
tests conclude with a done_testing() call.  While there, I also removed a few
exit(0) calls from individual tests making them more consistent.

Thoughts?

--
Daniel Gustafsson        https://vmware.com/


Attachment

pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)
Next
From: Daniel Gustafsson
Date:
Subject: Typo in archive modules docs