Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c) - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)
Date
Msg-id 20220209135230.yd4nsgxwvmltpude@jrouhaud
Whole thread Raw
In response to [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)  (Ranier Vilela <ranier.vf@gmail.com>)
List pgsql-hackers
Tree view 
Hi,

On Wed, Feb 09, 2022 at 07:56:35AM -0300, Ranier Vilela wrote:
> 
> I think this change can improve this particular function by avoiding
> touching value if not needed.
> Test if not isnull is cheaper than test TupleDescAttr is -1.

It looks sensible.

pgsql-hackers by date:

Previous
From: Bernd Helmle
Date:
Subject: Re: is the base backup protocol used by out-of-core tools?
Next
From: Daniel Gustafsson
Date:
Subject: Replacing TAP test planning with done_testing()