Postgres Pro
Downloads
Home   >   mailing lists

[PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)
Date
Msg-id CAEudQApq+wJJyFHQ9iYGrd2vUK+Uk1i214KsBewe7nkvcWYBaQ@mail.gmail.com
Whole thread Raw
Responses Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)  (Julien Rouhaud <rjuju123@gmail.com>)
Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)  (Dong Wook Lee <sh95119@gmail.com>)
List pgsql-hackers
Tree view
Hi,

I think this change can improve this particular function by avoiding touching value if not needed.
Test if not isnull is cheaper than test TupleDescAttr is -1.

best regards,

Ranier Vilela
Attachment

pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: Make relfile tombstone files conditional on WAL level
Next
From: Ranier Vilela
Date:
Subject: Possible uninitialized use of the variables (src/backend/access/transam/twophase.c)