Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c) - Mailing list pgsql-hackers

From Dong Wook Lee
Subject Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)
Date
Msg-id CAAcByaJK_ivH2555T2kwDa4h67eh+U8eXTRctp_OjodmFyctXw@mail.gmail.com
Whole thread Raw
In response to [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)  (Ranier Vilela <ranier.vf@gmail.com>)
Responses Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)
List pgsql-hackers
Tree view 
Hi,

I've applied your patch. I think it's reasonable.
but  IMHO It looks more complicated to read because of many conditions
in if statement.
so what about just moving up if-statement?

Thanks.
Dong Wook Lee

2022년 2월 9일 (수) 오후 7:56, Ranier Vilela <ranier.vf@gmail.com>님이 작성:
>
> Hi,
>
> I think this change can improve this particular function by avoiding touching value if not needed.
> Test if not isnull is cheaper than test TupleDescAttr is -1.
>
> best regards,
>
> Ranier Vilela
Attachment

pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: Add tag/category to the commitfest app
Next
From: Dagfinn Ilmari Mannsåker
Date:
Subject: Re: Replacing TAP test planning with done_testing()