Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c) - Mailing list pgsql-hackers

From Dong Wook Lee
Subject Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)
Date
Msg-id CAAcByaL6aPLbFK6WfT-U6PzvwPUx3QxxCo64smTvS=4zE_mqsg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)  (Dong Wook Lee <sh95119@gmail.com>)
Responses Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Tree view 
Oops, I realized that I made a mistake in my patch and now I have corrected it.

2022년 2월 9일 (수) 오후 11:33, Dong Wook Lee <sh95119@gmail.com>님이 작성:
>
> Hi,
>
> I've applied your patch. I think it's reasonable.
> but  IMHO It looks more complicated to read because of many conditions
> in if statement.
> so what about just moving up if-statement?
>
> Thanks.
> Dong Wook Lee
>
> 2022년 2월 9일 (수) 오후 7:56, Ranier Vilela <ranier.vf@gmail.com>님이 작성:
> >
> > Hi,
> >
> > I think this change can improve this particular function by avoiding touching value if not needed.
> > Test if not isnull is cheaper than test TupleDescAttr is -1.
> >
> > best regards,
> >
> > Ranier Vilela
Attachment

pgsql-hackers by date:

Previous
From: Dagfinn Ilmari Mannsåker
Date:
Subject: Re: Replacing TAP test planning with done_testing()
Next
From: Ashutosh Sharma
Date:
Subject: Re: Identify missing publications from publisher while create/alter subscription.