Re: SP-GiST for ranges based on 2d-mapping and quad-tree - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: SP-GiST for ranges based on 2d-mapping and quad-tree
Date
Msg-id CAPpHfduSGrOK++KvzLpHY0gpRZiNvN6CUXHfK92KEjn3-WwYCg@mail.gmail.com
Whole thread Raw
In response to Re: SP-GiST for ranges based on 2d-mapping and quad-tree  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: SP-GiST for ranges based on 2d-mapping and quad-tree  (Jeff Davis <pgsql@j-davis.com>)
List pgsql-hackers
On Sun, Oct 21, 2012 at 11:22 AM, Jeff Davis <pgsql@j-davis.com> wrote:
On Tue, 2012-09-04 at 17:45 +0400, Alexander Korotkov wrote:
> On Mon, Aug 20, 2012 at 12:25 AM, Jeff Davis <pgsql@j-davis.com>
> wrote:
>         I am taking a look at this patch now. A few quick comments:
>
>         * It looks like bounds_adjacent modifies it's by-reference
>         arguments,
>         which is a little worrying to me. The lower/upper labels are
>         flipped
>         back, but the inclusivities are not. Maybe just pass by value
>         instead?
>
>         * Bounds_adjacent is sensitive to the argument order. Can't it
>         just take
>         bound1 and bound2?
>
>
> Fixed. Patch is attached.
>
It looks like this is basically the same diff as v0.1. Did something get
mixed up?
 
Right version of patch is attached.

------
With best regards,
Alexander Korotkov.
Attachment

pgsql-hackers by date:

Previous
From: "Etsuro Fujita"
Date:
Subject: Re: Comment typo
Next
From: Alexander Korotkov
Date:
Subject: Re: gistchoose vs. bloat