Re: SP-GiST for ranges based on 2d-mapping and quad-tree - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: SP-GiST for ranges based on 2d-mapping and quad-tree
Date
Msg-id 1350804174.27983.23.camel@jdavis
Whole thread Raw
In response to Re: SP-GiST for ranges based on 2d-mapping and quad-tree  (Alexander Korotkov <aekorotkov@gmail.com>)
Responses Re: SP-GiST for ranges based on 2d-mapping and quad-tree  (Alexander Korotkov <aekorotkov@gmail.com>)
List pgsql-hackers
On Tue, 2012-09-04 at 17:45 +0400, Alexander Korotkov wrote:
> On Mon, Aug 20, 2012 at 12:25 AM, Jeff Davis <pgsql@j-davis.com>
> wrote:
>         I am taking a look at this patch now. A few quick comments:
>         
>         * It looks like bounds_adjacent modifies it's by-reference
>         arguments,
>         which is a little worrying to me. The lower/upper labels are
>         flipped
>         back, but the inclusivities are not. Maybe just pass by value
>         instead?
>         
>         * Bounds_adjacent is sensitive to the argument order. Can't it
>         just take
>         bound1 and bound2?
> 
> 
> Fixed. Patch is attached.
> 
It looks like this is basically the same diff as v0.1. Did something get
mixed up?

Regards,Jeff Davis





pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: gistchoose vs. bloat
Next
From: Magnus Hagander
Date:
Subject: Re: Deprecations in authentication