Postgres Pro
Downloads
Home   >   mailing lists

Re: SP-GiST for ranges based on 2d-mapping and quad-tree - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: SP-GiST for ranges based on 2d-mapping and quad-tree
Date
Msg-id CAPpHfduemSNpt38yJdhUj1kfwERX792QmxyB=iL2=bkHAEwfpA@mail.gmail.com
Whole thread Raw
In response to Re: SP-GiST for ranges based on 2d-mapping and quad-tree  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: SP-GiST for ranges based on 2d-mapping and quad-tree  (Jeff Davis <pgsql@j-davis.com>)
List pgsql-hackers
Tree view
On Mon, Aug 20, 2012 at 12:25 AM, Jeff Davis <pgsql@j-davis.com> wrote:
I am taking a look at this patch now. A few quick comments:

* It looks like bounds_adjacent modifies it's by-reference arguments,
which is a little worrying to me. The lower/upper labels are flipped
back, but the inclusivities are not. Maybe just pass by value instead?

* Bounds_adjacent is sensitive to the argument order. Can't it just take
bound1 and bound2?

Fixed. Patch is attached.

------
With best regards,
Alexander Korotkov.
Attachment

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: Statistics and selectivity estimation for ranges
Next
From: Bruce Momjian
Date:
Subject: Re: 9.2 pg_upgrade regression tests on WIndows