Postgres Pro
Downloads
Home   >   mailing lists

Re: On login trigger: take three - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: On login trigger: take three
Date
Msg-id CAPpHfdsbD9sxJFwhSnbcgvii0=gT+7j3XPumNDHZW=mHmVoxOg@mail.gmail.com
Whole thread Raw
In response to Re: On login trigger: take three  (Michael Paquier <michael@paquier.xyz>)
Responses Re: On login trigger: take three  (Mikhail Gribkov <youzhick@gmail.com>)
Re: On login trigger: take three  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
Tree view 
On Mon, Oct 16, 2023 at 4:00 AM Michael Paquier <michael@paquier.xyz> wrote:
> On Mon, Oct 16, 2023 at 02:47:03AM +0300, Alexander Korotkov wrote:
> > The attached revision fixes test failures spotted by
> > commitfest.cputube.org.  Also, perl scripts passed perltidy.
>
> Still you've missed a few things.  At quick glance:
> - The code indentation was off a bit in event_trigger.c.
> - 005_login_trigger.pl fails if the code is compiled with
> ENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS because a WARNING is
> reported in test "create tmp objects: err equals".
> - 005_sspi.pl is older than the new test 005_login_trigger.pl, could
> you rename it with a different number?

You are very fast and sharp eye!
Thank you for fixing the indentation.  I just pushed fixes for the rest.

------
Regards,
Alexander Korotkov

pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Check each of base restriction clauses for constant-FALSE-or-NULL
Next
From: Michael Paquier
Date:
Subject: Re: Add support for AT LOCAL